chore(release): update charts and tags for v0.9.1-rc.1#3660
chore(release): update charts and tags for v0.9.1-rc.1#3660jaellio merged 1 commit intoopenservicemesh:release-v0.9from
Conversation
| updatedMeshConfigData: &v1alpha1.MeshConfigSpec{ | ||
| Sidecar: v1alpha1.SidecarSpec{ | ||
| InitContainerImage: "openservicemesh/init:v0.8.2", | ||
| InitContainerImage: "openservicemesh/init:v0.9.0", |
There was a problem hiding this comment.
Shouldn't this also be v0.9.1-rc.1 ?
There was a problem hiding this comment.
This value doesn't need to be updated each time since it doesn't relate to the current version at all.
I'd be in favor of (outside of this PR) changing this to something like TEST just to make it obvious that the exact value doesn't really matter as long as it's different from the default.
There was a problem hiding this comment.
This method is testing updates to the mesh config. I don't think the version number matters as long as it is different from the above version number (in this case v0.9.1-rc.1)
| updatedMeshConfigData: &v1alpha1.MeshConfigSpec{ | ||
| Sidecar: v1alpha1.SidecarSpec{ | ||
| InitContainerImage: "openservicemesh/init:v0.8.2", | ||
| InitContainerImage: "openservicemesh/init:v0.9.0", |
There was a problem hiding this comment.
This value doesn't need to be updated each time since it doesn't relate to the current version at all.
I'd be in favor of (outside of this PR) changing this to something like TEST just to make it obvious that the exact value doesn't really matter as long as it's different from the default.
jaellio
force-pushed
the
release-v0.9.1-rc.1
branch
from
09acbfb to
a1a6e43
Compare
Signed-off-by: jaellio <jaellio@microsoft.com>
jaellio
force-pushed
the
release-v0.9.1-rc.1
branch
from
a1a6e43 to
0ee5371
Compare
3 participants
Signed-off-by: jaellio jaellio@microsoft.com
I have cherry-picked any changes labelled
needs-cherry-pick-vX.Y.ZI have made all of the following version and patch updates:
I have checked that the base branch for this PR is correct as defined by the release guide
Is this a release candidate?
Yes